1.5.x #350
Merged
1.5.x #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removing ruby-version file
Prior to this change, there was no method that returned the total timeouts of all of a command's hook scripts. This change adds this method, with tests, but does not use it yet.
Prior to this change, no logic existed to bounds- check the soon-to-come host command timeout duration field conditionally passed to put_host_command_acknowledgement This change adds that logic in a new class, CommandAcknowledgementRequestBuilder, but does not use it yet.
Prior to this change, the agent did not log anything to indicate in the hook script file that a script finished. This change adds those log statements.
This reverts commit 1f519a56f7333df543faae3e4eb74df9c9b7de30.
With this patch, the agent now checks for the presence of the DeploymentCommandTracker when the child process is started up. If the file is present, then we read the host_command_identifier from the file and then call PutHostCommandComplete Status=Failed to fast-fail the deployment.
Prior to this change, CodeDeploy Agent used aws-sdk-code-generator to turn JSON API definitions into Ruby source code. This change checks in the source code, which was generated ahead of time.
…ardless of other files in the root
Prior to this change, nested appspec handling occurred in the large CommandExecutor class. This is a large class with several responsibilities. This change extracts nested appspec handling logic out into a new class, without changing behavior.
Prior to this change, Windows deployments in Gamma failed with "appspec file not found". We suspect NestedAppspecHandler may be provided an incorrect delpoyment archive directory. This change logs the directory at debug level.
Prior to this change, NestedAppspecHandler failed when an archive path used backslash as a file separator. This change uses separate "globbers" for linux and windows.
Prior to this change, NestedAppspecHandler used Array.append, an alias to Array.push that was added in Ruby 2.5. We need to support older Ruby versions. This change changes to Arary.push.
Prior to this change, several recently introduced commits attempted to allow for a nested appspec with extraneous top-level files in the bundle. These changes introduced regressions. This change reverts the following commits: (most recent first) - 5d056b4ace47655090a3fe04165533618ebaeff1 - 84e787c5532a378309cbcea0d93b09124a1c1551 - 17d5b9260da2978468aa3774ac9a40e426f0b2ba - d4561a85a99b7e80743d3423a06a1d8b4f190224 - d946529ea61880fac59c1e02e99c36ec2ee0bd61 - c9c0399da9cf4c6949c4aeab508918332163865c - ef24b6cedf4acb6f80fd0e5fcd4260a2d89f9804
puneethnr
approved these changes
Apr 3, 2023
aj-aws
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#349
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.