Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move After to proper systemd unit file section. #310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pdrakeweb
Copy link
Contributor

Move the After= configuration statement from the [Service] section to the [Unit] section where it belongs.

The current code results in syslog messages like this:

11/05/2021
5:35:48.546 AM +0000
service.systemd v2 i-###########.us-east-1a ##.##.##.## undef 4 [/etc/systemd/system/codedeploy-agent.service:6] Unknown lvalue 'After' in section 'Service'

See syslog documentation for supporting evidence:
https://www.freedesktop.org/software/systemd/man/systemd.unit.html
https://www.freedesktop.org/software/systemd/man/systemd.service.html

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Nov 19, 2021

Coverage Status

Coverage remained the same at 47.849% when pulling c3f315d on pdrakeweb:service-after into 3c39d54 on aws:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants