Skip to content

Conversation

ubaskota
Copy link

@ubaskota ubaskota commented Sep 3, 2025

Description of changes:
Amazon sms is no longer publicly active. This PR will remove the, now deprecated, sms service from AWS CLI.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aemous aemous requested a review from a team September 4, 2025 14:07
Copy link
Contributor

@aemous aemous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove /tests/functional/botocore/endpoint-rules/sms

Otherwise looks good

@ubaskota
Copy link
Author

ubaskota commented Sep 4, 2025

/tests/functional/botocore/endpoint-rules/sms removed

@aemous aemous self-requested a review September 4, 2025 16:08
Copy link
Contributor

@aemous aemous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kdaily kdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment on the botocore version of this change applies to CLI v2 as well:

boto/botocore#3555 (comment)

Code:

'sms.GetReplicationRuns.replicationJob',
'sms.GetServers.lastModifiedOn',
'sms.GetServers.serverCatalogStatus',

@ubaskota
Copy link
Author

I think this comment on the botocore version of this change applies to CLI v2 as well:

boto/botocore#3555 (comment)

Code:

'sms.GetReplicationRuns.replicationJob',
'sms.GetServers.lastModifiedOn',
'sms.GetServers.serverCatalogStatus',

Addressed

@ubaskota ubaskota requested a review from kdaily September 15, 2025 15:36
Copy link
Member

@kdaily kdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please clean up the commits and squash them before merging, though, thanks!

@arandito arandito merged commit 4871349 into aws:v2 Sep 15, 2025
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants