-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Remove sms client following the service deprecation #9697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also remove /tests/functional/botocore/endpoint-rules/sms
Otherwise looks good
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comment on the botocore
version of this change applies to CLI v2 as well:
Code:
aws-cli/tests/functional/botocore/test_paginator_config.py
Lines 120 to 122 in b8a7a43
'sms.GetReplicationRuns.replicationJob', | |
'sms.GetServers.lastModifiedOn', | |
'sms.GetServers.serverCatalogStatus', |
Addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please clean up the commits and squash them before merging, though, thanks!
Description of changes:
Amazon sms is no longer publicly active. This PR will remove the, now deprecated, sms service from AWS CLI.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.