Deleting all versions of objects #9637
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakshil14-2
force-pushed
the
delete-versions
branch
from
99de066 to
979808e
Compare
rakshil14-2
force-pushed
the
delete-versions
branch
from
979808e to
cf2392e
Compare
rakshil14-2
changed the title
aemous
requested changes
Aug 7, 2025
rakshil14-2
force-pushed
the
delete-versions
branch
from
cab6975 to
a8c88b5
Compare
kdaily
reviewed
Aug 12, 2025
rakshil14-2
force-pushed
the
delete-versions
branch
from
e02c3f9 to
f9a1810
Compare
added 2 commits
August 15, 2025 11:55
Adding response to delete handler
Updated comments Remove BucketLister class Added change logs Modifying S3 Handler Format display message Changing names of the class changing to marked down
rakshil14-2
force-pushed
the
delete-versions
branch
from
f9a1810 to
4fb3893
Compare
kdaily
reviewed
Aug 15, 2025
| result_queue, result_recorder, result_processor | ||
| ) | ||
|
|
||
| if self._requires_batch_handler(): |
There was a problem hiding this comment.
I'm not 100% sure about adding logic to change the type returned. In the function signature it says:
:returns: A S3TransferHandler instance
Does a BatchS3TransferHandler act like the existing S3TransferHandler?
There was a problem hiding this comment.
Yes, but BatchS3TransferHandler will handler batching operations
aemous
reviewed
Aug 22, 2025
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "type": "enhancement", | |||
| "category": "`s3`", | |||
There was a problem hiding this comment.
nit: I think this should have two ticks on both sides. ``s3``
kdaily
requested changes
Oct 6, 2025
| cli_params, | ||
| ) | ||
| # Submitter list for batch request submitters | ||
| self._batch_submitters = [ |
There was a problem hiding this comment.
Could this be:
Suggested change
| self._batch_submitters = [ | |
| self._submitters = [ |
to follow the same interface as the S3TransferHandler?
Comment on lines
+728
to
+729
| :type versionedFileInfo: Set of VersionedFileInfo to submit to batch submitter | ||
| :param fileinfos: The fileinfos to submit to the batch submitter |
There was a problem hiding this comment.
I think keeping the same structure as the existing handler would be preferrable to describe, since the only underlying changes are the type of iterable and the submitters being called on them.
Suggested change
| :type versionedFileInfo: Set of VersionedFileInfo to submit to batch submitter | |
| :param fileinfos: The fileinfos to submit to the batch submitter | |
| :type fileinfos: iterable of VersionedFileInfos | |
| param fileinfos: Set of VersionedFileInfos to submit to underlying transfer | |
| request submitters to make transfer API calls to S3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue :#4070
Description of changes:
Added a flag for deleting all versions of an object present in a versioned-enable bucket. For dealing with versions, a
list-object-versionsapi is called to get theversion idsas well asdelete markersof the objects. Once the object and their version ids are retrieved, then a batch of objects with their version id is created which is passed todelete-objectsapi for deletion.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.