Remove f-strings to preserve error message on Python 2.7 #6999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-sdk-python-automation
added a commit
that referenced
this pull request
May 31, 2022
* release-1.25.0: Bumping version to 1.25.0 Add changelog entries from botocore Update changelog based on model updates Drop support for Python 3.6 (#6990) Remove f-strings to preserve error message on Python 2.7 (#6999) Move install script to use python -m pip (#6982) Fix #3618 s3uploader writing to stdout
ConnorKirk
pushed a commit
to ConnorKirk/aws-cli
that referenced
this pull request
Oct 28, 2022
godd9170
pushed a commit
to godd9170/aws-cli
that referenced
this pull request
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message for unsupported versions broke for Python 2.7 in #6982 due to the inclusion of f-strings. We'll keep the deprecation notice for the time being and revert back to basic
formatcalls for the install commands.