Skip to content

Conversation

@iliapolo
Copy link
Contributor

@iliapolo iliapolo commented May 7, 2020

Commit Message

chore(cli): exclude outputs test from regression suite (#7855)

#7854 fixed the test, but the regression suite runs the same test from the previous version, which cannot be fixed. So we exclude this test from the current suite.

End Commit Message


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 7, 2020
@iliapolo iliapolo requested a review from a team May 7, 2020 21:37
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if I can clear these exclusions, but it seems reasonable for now.

@iliapolo
Copy link
Contributor Author

iliapolo commented May 7, 2020

I'll see if I can clear these exclusions, but it seems reasonable for now.

We don't need to clear them as they are per version. Once the next version is released they will be effectively ignored.

@iliapolo iliapolo merged commit baeca9d into master May 7, 2020
@iliapolo iliapolo deleted the epolon/exclude-outputs-integ-test branch May 7, 2020 21:41
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: df7d462
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 008f23d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants