Skip to content

Conversation

@efekarakus
Copy link
Contributor

@efekarakus efekarakus commented May 7, 2020

Support multiple security groups when creating an ec2 or fargate service.

Resolves #2540, #7698


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@efekarakus
Copy link
Contributor Author

Dedupe of #3985, #7813. The "Allow edits by maintainers" toggle wouldn't work in the previous PR so I closed it and re-created the PR.

Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 💯

@piradeepk piradeepk changed the title feat(ecs): support multiple security groups when creating an ecs service feat(ecs): support multiple security groups when creating an ec2service May 7, 2020
@piradeepk piradeepk changed the title feat(ecs): support multiple security groups when creating an ec2service feat(ecs): support multiple security groups when creating an ec2 or fargate service May 7, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a68b743
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 7, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ff5a486
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 7, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 456c469 into aws:master May 7, 2020
@efekarakus efekarakus deleted the robertd/ecs-multiple-security-groups branch August 27, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-ecs Related to Amazon Elastic Container

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple security groups associated to a fargate service

4 participants