Skip to content

Conversation

@skinny85
Copy link
Contributor

@skinny85 skinny85 commented Apr 29, 2020

Commit Message

feat(codebuild): add support for test reports

This adds support for CodeBuild's test reports feature.
It includes a new Layer 2 class, ReportGroup.

The default project's IAM role has been augmented with permissions
to create and use test result groups whose names begin with the project's name
(as that is what the default report group created when putting a simple name in the
'reports' buildspec section is called).
There is a new boolean property when creating the project,
addCreateReportGroupPermissions,
that can be used to turn off this behavor.

Fixes #7367

End Commit Message


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: cebd527
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Apr 30, 2020
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved modulo renames

@polothy
Copy link
Contributor

polothy commented May 4, 2020

This looks awesome! Was just looking to do this today. 🤞 that is merges soon so I can be lazy and not do it myself 😄

@skinny85 skinny85 force-pushed the feat/codebuild-test-reports branch from cebd527 to c7bce03 Compare May 4, 2020 22:38
@skinny85 skinny85 requested a review from rix0rrr May 4, 2020 22:39
@skinny85
Copy link
Contributor Author

skinny85 commented May 4, 2020

@rix0rrr included your comments, would appreciate a quick re-review! (I get that you approved these already, but there are enough changes since the last revision that I think another glance is justified here)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c7bce03
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 force-pushed the feat/codebuild-test-reports branch from c7bce03 to 16c694d Compare May 5, 2020 18:14
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 16c694d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 force-pushed the feat/codebuild-test-reports branch from 16c694d to 980146f Compare May 5, 2020 20:32
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 980146f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved modulo small tweaks

@skinny85 skinny85 force-pushed the feat/codebuild-test-reports branch from 980146f to 539ff62 Compare May 6, 2020 17:18
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 539ff62
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

This adds support for CodeBuild's test reports feature.
It includes a new Layer 2 class, ReportGroup.

The default project's IAM role has been augmented with permissions
to create and use test result groups whose names begin with the project's name
(as that is what the default report group created when putting a simple name in the
'reports' buildspec section is called).
There is a new boolean property when creating the project,
addCreateReportGroupPermissions,
that can be used to turn off this behavor.

Fixes aws#7367
@skinny85 skinny85 force-pushed the feat/codebuild-test-reports branch from 539ff62 to 1263846 Compare May 6, 2020 18:50
@skinny85 skinny85 removed the pr/do-not-merge This PR should not be merged at this time. label May 6, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1263846
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 6, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c1bce39
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 6, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4befefc into aws:master May 6, 2020
@skinny85 skinny85 deleted the feat/codebuild-test-reports branch May 6, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CodeBuild buildspec reports — Not authorized to perform: codebuild:CreateReportGroup

4 participants