-
Notifications
You must be signed in to change notification settings - Fork 4.4k
chore: update minimum supported node version to 10.13.0 #7673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
thanks for getting this started @winky! seems like you need to merge and update a couple of modules that were added recently. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
discussed with @rix0rrr and we're okay with bumping up the min version here
Commit Message
chore: update minimum supported node version to 10.13.0 (#7673)
Users cannot go through our current contribution guide and successfully install the repo due to the
nockdependency, which now needs a minimum of Node 10.13.0.Closes #7671
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license