fix(amplify): cannot map branch to domain root #7621
Conversation
Correctly handle the default for `prefix`. An empty string now maps to the domain root. Also add a `mapRoot` method. Closes aws#7590
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
left a comment
MrArnoldPalmer
left a comment
There was a problem hiding this comment.
@jogold lets add a breaking change note in the PR message just to be safe? I doubt there are users currently using prefix: '' in the wild but better safe.
done |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
3 participants
Commit Message
fix(amplify): cannot map branch to domain root (#7621)
Correctly handle the default for
prefix. An empty string now maps to the domainroot. Also add a
mapRootmethod.Closes #7590
BREAKING CHANGE:
mapSubDomain()called with an empty string forprefixnowmaps to the domain root.
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license