chore(eslint): enable comma-dangle always-multiline #7409
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Need to update the integ test expectations, will do it if OK with the proposed linting rule. @nija-at? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@nija-at can you take a look when you have time? Considering the number of changes here, it will quickly become hard to rebase/merge from master if too many commits are added to master in the meantime. Thanks! |
nija-at
left a comment
nija-at
left a comment
There was a problem hiding this comment.
Thanks for doing this! Looks good to me!
| - [awslint](#awslint) | ||
|
|
||
| #### eslint | ||
| #### eslint |
There was a problem hiding this comment.
Guess I had a non-standard whitespace there. Thanks!
| 'quotes': [ 'error', 'single', { avoidEscape: true } ], | ||
| 'comma-dangle': [ 'error', 'always-multiline' ], // ensures clean diffs |
There was a problem hiding this comment.
can you add the link to the medium article here as well?
There was a problem hiding this comment.
done, can you reapprove?
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
1 similar comment
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Noticed this while massively updating integ test expectations for aws#7409. Seems like lots of expectation files where modified "by hand". Ensures cleaner diffs from now on. Methodology: * Comment out https://github.com/aws/aws-cdk/blob/d1b3b750cec3c514df6690e8baeffa7e9b260500/tools/cdk-integ-tools/bin/cdk-integ.ts#L38-L40 * `yarn lerna run integ --scope @aws-cdk/*`
Noticed this while massively updating integ test expectations for #7409. Seems like lots of expectation files were modified "by hand". Ensures cleaner diffs from now on. Methodology: * Comment out https://github.com/aws/aws-cdk/blob/d1b3b750cec3c514df6690e8baeffa7e9b260500/tools/cdk-integ-tools/bin/cdk-integ.ts#L38-L40 * `yarn lerna run integ --scope @aws-cdk/*`
3 participants
See here for only relevant change.
Commit Message
chore(eslint): enable comma-dangle always-multiline
This ensures clean diffs.
See https://medium.com/@nikgraf/why-you-should-enforce-dangling-commas-for-multiline-statements-d034c98e36f8
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license