Skip to content

Conversation

@shivlaks
Copy link
Contributor

@shivlaks shivlaks commented Apr 14, 2020

Commit Message

chore(stepfunctions): convert tests to jest (#7351)

I have not modified any of the tests in this PR and kept the scope to simply converting to jest.
Also added an override for the coverageThreshold as it's just a touch below (currently at 78) our configured global of 80. Hopefully we can get rid of that block soon as we start adding more tests in this module.

End Commit Message


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@shivlaks shivlaks added the @aws-cdk/aws-stepfunctions Related to AWS StepFunctions label Apr 14, 2020
@shivlaks shivlaks requested review from a team and nija-at April 14, 2020 20:57
@mergify mergify bot added contribution/core This is a PR that came from AWS. labels Apr 14, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 62596eb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7695f2b into master Apr 15, 2020
@mergify mergify bot deleted the shivlaks/stepfunctions-jest-the-tests branch April 15, 2020 10:07
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d10697f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-stepfunctions Related to AWS StepFunctions contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants