feat(batch): ec2 launch template support #6602

andrestone · 2020-03-05T17:32:49Z

! Integration tests are failing on master, waiting for this fix to be merged.

Launch template support

Related issues:

close #3536 - add batch pattern constructs #4732 (comment)

Usage

Simply define your Launch Template:

    const myLaunchTemplate = new ec2.CfnLaunchTemplate(this, 'LaunchTemplate', {
      launchTemplateName: 'extra-storage-template',
      launchTemplateData: {
        blockDeviceMappings: [
          {
            deviceName: '/dev/xvdcz',
            ebs: {
              encrypted: true,
              volumeSize: 100,
              volumeType: 'gp2'
            }
          }
        ]
      }
    });

and use it:

    const myComputeEnv = new batch.ComputeEnvironment(this, 'ComputeEnv', {
      computeResources: {
        launchTemplate: {
          launchTemplateName: myLaunchTemplate.launchTemplateName as string, //or simply use an existing template name
        },
        vpc,
      },
      computeEnvironmentName: 'MyStorageCapableComputeEnvironment',
    });

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation · 2020-03-05T17:50:29Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 39d1565
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-05T18:02:53Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 50ed7a4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

iliapolo

Just docstrings, code looks good. Also, lets align the PR description with #6549 (comment).

Thanks!

packages/@aws-cdk/aws-batch/lib/compute-environment.ts

iliapolo · 2020-03-06T18:50:58Z

@andrestone I love it, so clean!

Pull request has been modified.

aws-cdk-automation · 2020-03-06T19:30:13Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 5239658
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

andrestone · 2020-03-06T19:41:35Z

I guess it's mergeable now?
Thanks!

aws-cdk-automation · 2020-03-06T19:59:18Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 900e657
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

iliapolo · 2020-03-06T20:07:26Z

I guess it's mergeable now?
Thanks!

This wasn't merged yet: #6549

Also the PR description thing

andrestone · 2020-03-06T20:09:24Z

Wouldn't the squash commit be ok as well?

…

On Fri, Mar 6, 2020, 21:07 Eli Polonsky ***@***.***> wrote: I guess it's mergeable now? Thanks! This wasn't merged yet: #6549 <#6549> Also the PR description thing — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6602?email_source=notifications&email_token=AB4W4RVTP3GV564K3YFWWOLRGFJX7A5CNFSM4LCO47P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOCWHWI#issuecomment-595944409>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4W4RXNPDE5Y6WKLQIGF53RGFJX7ANCNFSM4LCO47PQ> .

iliapolo · 2020-03-06T20:27:29Z

Wouldn't the squash commit be ok as well?

Whoops sorry, didn't notice it. Yeap all good. You just need to re-run CodeBuild project by pushing a dummy commit.

aws-cdk-automation · 2020-03-06T20:53:15Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: d2e3e30
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

andrestone · 2020-03-06T21:16:11Z

Maaaaaa bad. Gotta remake expected.json

iliapolo · 2020-03-06T21:38:40Z

Are you running ‘yarn integ’ to produce the expected template?

andrestone · 2020-03-06T22:04:47Z

yep

…

On Fri, Mar 6, 2020 at 10:38 PM Eli Polonsky ***@***.***> wrote: Are you running ‘yarn integ’ to produce the expected template? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6602?email_source=notifications&email_token=AB4W4RWULAWILW6QVZ7NGCTRGFUOBA5CNFSM4LCO47P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOC6AFA#issuecomment-595976212>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4W4RX3A6XCZSK4WYUWXT3RGFUOBANCNFSM4LCO47PQ> .

andrestone · 2020-03-06T23:14:07Z

Ma bad, build passed.

aws-cdk-automation · 2020-03-06T23:53:30Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 07322be
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-03-07T10:16:37Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2020-03-07T10:58:34Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 376d49b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-03-07T10:59:02Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

andrestone mentioned this pull request Mar 5, 2020

fix(batch): managed compute environment now properly works with compute resources and instanceRole has correct docstring and type definition #6549

Merged

andrestone marked this pull request as ready for review March 5, 2020 20:43

andrestone mentioned this pull request Mar 5, 2020

close #3536 - add batch pattern constructs #4732

Merged

iliapolo previously requested changes Mar 6, 2020

View reviewed changes

packages/@aws-cdk/aws-batch/lib/compute-environment.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-batch/lib/compute-environment.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-batch/lib/compute-environment.ts Outdated Show resolved Hide resolved

andrestone force-pushed the feat-aws-batch-launch-template branch from 5239658 to 900e657 Compare March 6, 2020 19:40

SomayaB assigned iliapolo Mar 6, 2020

andrestone force-pushed the feat-aws-batch-launch-template branch from 900e657 to d2e3e30 Compare March 6, 2020 20:31

feat(batch): ec2 launch template support

07322be

andrestone force-pushed the feat-aws-batch-launch-template branch from d2e3e30 to 07322be Compare March 6, 2020 22:58

iliapolo mentioned this pull request Mar 7, 2020

AWS Batch JobQueue does not provide computeResources required for managed ComputeEnvironment #6615

Closed

iliapolo approved these changes Mar 7, 2020

View reviewed changes

Merge branch 'master' into feat-aws-batch-launch-template

376d49b

mergify bot merged commit 2b02693 into aws:master Mar 7, 2020

eladb pushed a commit that referenced this pull request Mar 9, 2020

feat(batch): ec2 launch template support (#6602)

8a9bfe6

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

horsmand pushed a commit to horsmand/aws-cdk that referenced this pull request Mar 9, 2020

feat(batch): ec2 launch template support (aws#6602)

0e14230

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

snyk-bot mentioned this pull request Apr 10, 2020

[Snyk] Upgrade aws-cdk from 1.28.0 to 1.30.0 ammobinDOTca/ammobin-cdk#2

Closed

feat(batch): ec2 launch template support #6602

feat(batch): ec2 launch template support #6602

Uh oh!

Conversation

andrestone commented Mar 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Launch template support

Related issues:

Usage

Uh oh!

aws-cdk-automation commented Mar 5, 2020

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Mar 5, 2020

AWS CodeBuild CI Report

Uh oh!

iliapolo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iliapolo commented Mar 6, 2020

Uh oh!

aws-cdk-automation commented Mar 6, 2020

AWS CodeBuild CI Report

Uh oh!

andrestone commented Mar 6, 2020

Uh oh!

aws-cdk-automation commented Mar 6, 2020

AWS CodeBuild CI Report

Uh oh!

iliapolo commented Mar 6, 2020

Uh oh!

andrestone commented Mar 6, 2020 via email

Uh oh!

iliapolo commented Mar 6, 2020

Uh oh!

aws-cdk-automation commented Mar 6, 2020

AWS CodeBuild CI Report

Uh oh!

andrestone commented Mar 6, 2020

Uh oh!

iliapolo commented Mar 6, 2020

Uh oh!

andrestone commented Mar 6, 2020 via email

Uh oh!

andrestone commented Mar 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aws-cdk-automation commented Mar 6, 2020

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Mar 7, 2020

Uh oh!

aws-cdk-automation commented Mar 7, 2020

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Mar 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andrestone commented Mar 5, 2020 •

edited

Loading

andrestone commented Mar 6, 2020 •

edited

Loading