fix(cli): fast "no-op" deploys do not consider tags #6472
Conversation
Stack-level tags apply to all supported resources in a stack. If they change, a fast "no-op" deploy should not occur (e.g. a tag with the CDK version or a tag with the commit hash when running in CI). Fix the `'deploy not skipped if template changed'` test that was including the `force` option. Fix CLI integ tests not working anymore after aws#6463 and the `0.0.0` version.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @aws-cdk/aws-ecr-assets \ | ||
| @aws-cdk/aws-cloudformation \ | ||
| @aws-cdk/aws-ec2 | ||
| @aws-cdk/core@^1 \ |
There was a problem hiding this comment.
Why? I think this will conflict with our new 0.0.0 dev version
There was a problem hiding this comment.
I cannot get the cli integ test to work (prepare fixture) without this change. I get a npm error saying that it cannot find version 0.0.0 of those packages. Can you try?
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
3 participants
Stack-level tags apply to all supported resources in a stack. If they change, a
fast "no-op" deploy should not occur (e.g. a tag with the CDK version or a tag
with the commit hash when running in CI) because resources should be
updated.
Fix the
'deploy not skipped if template changed'test that was including theforceoption.Fix CLI integ tests not working anymore after #6463 and the
0.0.0version.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license