fix(docker): cannot use cdk docker assets as base image

[jogold]

Ensure docker login is called before docker build to allow using cdk docker
assets as base image for other docker assets.

Fixes #6466

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: a6ae88f
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[eladb]

@rix0rrr please see this, as it may also need to be reflected in CDK-assets.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 495c711
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[rix0rrr]

@jogold how do you reference other assets? Their build order is not guaranteed and I would consider their local names an implementation detail (and their remote names a deployment order detail), so I'm curious how you would go about this in practice in a way that's not liable to break?

[jogold]

@jogold how do you reference other assets? Their build order is not guaranteed and I would consider their local names an implementation detail (and their remote names a deployment order detail), so I'm curious how you would go about this in practice in a way that's not liable to break?

See #6466 where I describe a pattern to do this.