Skip to content

Conversation

@eladb
Copy link
Contributor

@eladb eladb commented Feb 26, 2020

Since updates will cause a dismissal of approvals, indicate in the mergify comment that users should not update manually.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…approval

Since updates will cause a dismissal of approvals, indicate in the mergify comment that users should not update manually.
.mergify.yml Outdated
actions:
comment:
message: Thank you for contributing! Your pull request is now being automatically merged without squashing.
message: Thank you for contributing! Your pull request will be updated from master and then merged automatically without sqaushing (do not update manually).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, might be worthwhile to toss in this link as well, because ppl need to have "maintainers can push to fork" enabled (and it cannot be enabled in forks based in organizations).

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the typo. Not exactly understand how this link should be added. Perhaps you can just suggest a phrasing with this link inside?

@eladb eladb requested a review from rix0rrr February 26, 2020 10:41
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7a9923c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: e26aa80
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this maybe?

Elad Ben-Israel and others added 2 commits February 26, 2020 15:22
Co-Authored-By: Rico Huijbers <[email protected]>
Co-Authored-By: Rico Huijbers <[email protected]>
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ff3bb5a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 9319917
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb merged commit cb71239 into master Feb 26, 2020
@eladb eladb deleted the benisrae/improve-mergify-message branch February 26, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants