fix(core): enableVersionUpgrade in CfnUpdatePolicy #6434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an Elasticsearch instance in the CDK, you are unable to specify how the instance should be upgraded. This functionality is present in CloudFormation, however it was missed in the CDK. This fix adds the `enableVersionUpgrade` property to the CfnUpdatePolicy interface. Fixes: aws#6158
JackChap
approved these changes
Feb 25, 2020
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Feb 26, 2020
eladb
changed the title
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an Elasticsearch instance in the CDK, you are unable to
specify how the instance should be upgraded. This functionality is
present in CloudFormation, however it was missed in the CDK.
This fix adds the
enableVersionUpgradeproperty to the CfnUpdatePolicyinterface.
Fixes: #6158
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license