feat(cognito): refresh modeling of import APIs, sign in & autoverified attrs #6422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d attrs * Switch to import UserPool based on ARN and Id. * IUserPool no longer defines provider information as members. * Rename `SignInType` to `SignInAlias`. Adjust its members so it's clearer on the options available. The CDK automatically figures out which ones are primary sign in attributes, and which ones are aliases. * `autoVerifiedAttributes` has a new type - `AutoVerifiedAttrs` - instead of the overall UserPoolAttribute. The attributes to auto-verify are computed automatically based on the value specified in `SignInAlias` unless explicitly specified. BREAKING CHANGES: * `UserPool.fromUserPoolAttributes()` has been replaced by `fromUserPoolId()` and `fromUserPoolArn()`. * `IUserPool` no longer contains `userPoolProviderName` and `userPoolProviderUrl`. * `SignInType` has been removed and replaced by `SignInAlias`. While most of the attributes are retained as is, the attribute `EMAIL_OR_PHONE` has been dropped and `PREFERRED_USERNAME` has been added. * The property `signInType` has been removed and replaced by `signInAliases`. This is now a list of type `SignInAlias`. * The property `usernameAliasAttributes` has been dropped and its functionality merged with the `signInAliases` property. * default has changed for the `autoVerifiedAttributes` property for a UserPool.
nija-at
commented
Feb 24, 2020
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
added 2 commits
February 25, 2020 16:44
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
suggested changes
Feb 26, 2020
Contributor
eladb
left a comment
eladb
left a comment
There was a problem hiding this comment.
Looks good. Please fix the breaking changes section per my previous comment
eladb
approved these changes
Feb 26, 2020
Contributor
|
Thank you for contributing! Your pull request is now being automatically merged. |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request is now being automatically merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The awslint rule exclusion
no-unused-type:@aws-cdk/aws-cognito.UserPoolAttributeis temporary and will be removed in a subsequent PR.Commit Message
feat(cognito): refresh modeling of import APIs, sign in & autoverified attrs (#6422)
Switch to import UserPool based on ARN and Id.
IUserPool no longer defines provider information as members.
Rename
SignInTypetoSignInAliases. Switch from an enum to aninterface for better modeling. The CDK automatically figures out
which ones are primary sign in attributes, and which ones are
aliases.
autoVerifiedAttributesproperty is now renamed toautoVerifywitha modified type -
AutoVerifiedAttrs. The attributes to auto-verifyare computed automatically based on the value specified in
SignInAliasesunless explicitly specified.BREAKING CHANGE:
UserPool.fromUserPoolAttributes()has been replacedby
fromUserPoolId()andfromUserPoolArn().IUserPoolno longer containsuserPoolProviderNameand
userPoolProviderUrl.signInTypeofUserPoolhas beenrenamed to
signInAliasesand given a new typeSignInAliases. Thelist of sign in types are now specified via boolean properties.
usernameAliasAttributesofUserPoolhasbeen dropped and its functionality merged with the
signInAliasesproperty.
autoVerifiedAttributesforUserPoolisnow renamed to
autoVerifyand its default has now changed. The newdefault is now determined by the value of
signInAliases.