Make EventBridge EventPattern support content filtering (#6184) #6414

jmnarloch · 2020-02-24T01:26:06Z

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Summary

This is initial code review for supporting the EventBridge Content Filtering capabilities.

Issue: #6184

Highlights:

Changes the type of EventPattern attributes to []any.
Adds dedicated factory methods for dedicated filter type.
As there is know bug in CloudFormation for Rule handling all pattern matching is based on string values. See AWS::Events::Rule->EventPattern - Ability to supply a integer value aws-cloudformation/cloudformation-coverage-roadmap#251 (comment)

mergify · 2020-02-24T01:26:39Z

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

aws-cdk-automation · 2020-02-24T01:36:03Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 5f18ee6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-02-24T01:40:57Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 1e20493
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-02-24T01:41:49Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 3015f87
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jmnarloch · 2020-02-24T01:32:20Z

packages/@aws-cdk/aws-events/lib/matcher.ts

+     * Matches event based attribute value.
+     * @param values possible values to match the event attribute against
+     */
+    public static match(...values: string[]): any[] {


Alternatively instead of prefixing each method with match I was thinking about using just the matcher name.

This way matchPrefix() would become prefix(), matchAnythingBut() would be anythingBut() and so on.

If you rename the class as well, I think Match.prefix() would look pretty neat.

jmnarloch · 2020-02-24T01:33:08Z

packages/@aws-cdk/aws-events/lib/event-pattern.ts

   * @default - No filtering on version
   */
-  readonly version?: string[];
+  readonly version?: any[];


The big question is whether this is a backward compatible change across all CDK supported languages?

I don't think it will be. We probably shouldn't be doing this.

A solution is to use Tokens to force the output of the matcher functions to strings.

jmnarloch · 2020-02-24T01:33:58Z

packages/@aws-cdk/aws-events/lib/matcher.ts

+/**
+ * Event Pattern matcher.
+ */
+export abstract class Matcher {


The other option instead of introducing dedicated factory class is to include this functionality as part of EventPattern type.

jmnarloch · 2020-02-24T01:42:13Z

packages/@aws-cdk/aws-events/lib/matcher.ts

+     * Matches event based on presence or absence of attribute.
+     * @param value whether the attribute should exist or not
+     */
+    public static matchExists(value: boolean): any[] {


Does CDK's jsii allows to define default values for parameters? Like in this case value: boolean = true

aws-cdk-automation · 2020-02-24T01:48:12Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: e923cfa
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-02-24T01:50:32Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: c94cc2c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…aws#6184) Adds dedicated EventPattern factory methods for building the pattern.

aws-cdk-automation · 2020-02-24T02:44:43Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: d439d18
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rix0rrr · 2020-02-28T09:53:37Z

packages/@aws-cdk/aws-events/lib/event-pattern.ts

   * @default - No filtering on version
   */
-  readonly version?: string[];
+  readonly version?: any[];


I don't think it will be. We probably shouldn't be doing this.

A solution is to use Tokens to force the output of the matcher functions to strings.

rix0rrr · 2020-02-28T09:54:13Z

packages/@aws-cdk/aws-events/lib/matcher.ts

+     * Matches event based attribute value.
+     * @param values possible values to match the event attribute against
+     */
+    public static match(...values: string[]): any[] {


If you rename the class as well, I think Match.prefix() would look pretty neat.

rix0rrr · 2020-02-28T09:54:29Z

packages/@aws-cdk/aws-events/lib/matcher.ts

+     * Matches event based on presence or absence of attribute.
+     * @param value whether the attribute should exist or not
+     */
+    public static matchExists(value: boolean): any[] {


mergify · 2020-03-25T15:52:52Z

Once all the requested changes have been addressed, and the PR is ready for another review, remember to dismiss the review.

DavidChristiansen · 2020-12-10T17:38:25Z

Hi @jmnarloch are you going to be working on this or is it dead.

github-actions · 2022-03-16T20:06:25Z

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

jmnarloch force-pushed the content-filtering branch 2 times, most recently from 1e20493 to 3015f87 Compare February 24, 2020 01:29

jmnarloch force-pushed the content-filtering branch from 3015f87 to e923cfa Compare February 24, 2020 01:36

jmnarloch force-pushed the content-filtering branch from e923cfa to c94cc2c Compare February 24, 2020 01:41

jmnarloch commented Feb 24, 2020

View reviewed changes

jmnarloch mentioned this pull request Feb 24, 2020

AWS::Events::Rule->EventPattern - Ability to supply a integer value aws-cloudformation/cloudformation-coverage-roadmap#251

Closed

feat(events): Make EventBridge EventPattern support content filtering (…

d439d18

…aws#6184) Adds dedicated EventPattern factory methods for building the pattern.

jmnarloch force-pushed the content-filtering branch from c94cc2c to d439d18 Compare February 24, 2020 01:53

SomayaB assigned rix0rrr Feb 24, 2020

rix0rrr requested changes Feb 28, 2020

View reviewed changes

mina-asham mentioned this pull request Apr 14, 2020

feat(cloudfront): support geo restrictions for cloudfront distribution #7345

Merged

3 tasks

rix0rrr removed their assignment Jun 22, 2021

RomainMuller force-pushed the master branch from 924c117 to ebfd5f2 Compare September 29, 2021 13:07

cgarvis added p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Mar 10, 2022

github-actions bot closed this Mar 22, 2022

Make EventBridge EventPattern support content filtering (#6184) #6414

Make EventBridge EventPattern support content filtering (#6184) #6414

Uh oh!

Conversation

jmnarloch commented Feb 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

mergify bot commented Feb 24, 2020

Uh oh!

aws-cdk-automation commented Feb 24, 2020

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Feb 24, 2020

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Feb 24, 2020

AWS CodeBuild CI Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmnarloch Feb 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aws-cdk-automation commented Feb 24, 2020

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Feb 24, 2020

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Feb 24, 2020

AWS CodeBuild CI Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Mar 25, 2020

Uh oh!

DavidChristiansen commented Dec 10, 2020

Uh oh!

github-actions bot commented Mar 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jmnarloch commented Feb 24, 2020 •

edited

Loading

jmnarloch Feb 24, 2020 •

edited

Loading