fix(eks): default capacity uses desiredCapacity which is an anti-pattern #5651
Conversation
As described in #5215, `desiredCapacity` is not the recommended way to configure an auto scaling group since it will cause the ASG to reset the number of nodes in every CloudFormation deployment. Since EKS's default capacity uses `desiredCapacity` instead of `minCapacity`, as of #5507 this would emit a warning: "desiredCapacity has been configured. Be aware this will reset the size of your AutoScalingGroup on every deployment". This change modifies the behavior of the default capacity such that it will configure the ASG using `minCapacity` instead of `desiredCapacity` as recommended by ASG. Fixes #5650
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
left a comment
rix0rrr
left a comment
There was a problem hiding this comment.
Can't you just take a minCapacity and maxCapacity on the EKS cluster (with some reasonable defaults)? Or is this cluster not intended to autoscale?
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@rix0rrr wrote:
No, this cluster doesn't have auto scaling enabled, so I think this is fine. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request is now being automatically merged. |
3 participants
As described in #5215,
desiredCapacityis not the recommended way to configure an auto scaling group since it will cause the ASG to reset the number of nodes in every CloudFormation deployment. Since EKS's default capacity usesdesiredCapacityinstead ofminCapacity, as of #5507 this would emit a warning: "desiredCapacity has been configured. Be aware this will reset the size of your AutoScalingGroup on every deployment".This change modifies the behavior of the default capacity such that it will configure the ASG using
minCapacityinstead ofdesiredCapacityas recommended by ASG.Fixes #5650
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license