Follow up on PR #556 #562
Merged
Follow up on PR #556 #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use node.js "crypto" module instead of md5 * Remove `construct.name` (and fix all dependencies) * Remove non-alphanumeric after "Resource" is omitted BREAKING CHANGE: `construct.name` => `construct.id`
RomainMuller
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
construct.name, and fix all dependencies, including a bug discovered in the cloudtrail library that usedbucket.nameinstead ofbucket.bucketName(horray!)BREAKING CHANGE:
construct.name=>construct.idBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.