Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Aug 9, 2018

The vendored ZIPs we still have are causing problems for me when
switching branches.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

The vendored ZIPs we still have are causing problems for me when
switching branches.
@rix0rrr rix0rrr requested review from RomainMuller and eladb August 9, 2018 08:18
@RomainMuller
Copy link
Contributor

Do we still vendor in .zip files?

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Aug 9, 2018

We don't, this was a problem when working on a branch forked from an old master.

Annotation is still valid though.

@RomainMuller
Copy link
Contributor

Yes :)

@rix0rrr rix0rrr merged commit 7cfd5b5 into master Aug 9, 2018
@rix0rrr rix0rrr deleted the huijbers/more-gitattributes branch August 9, 2018 13:03
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants