Skip to content

Conversation

@eladb
Copy link
Contributor

@eladb eladb commented Aug 8, 2018

  • Bump
  • Added a bump.sh script ;-)

Fixes #467 (via aws/jsii#139)
Fixes #503 (via #517)
Fixes #502 (via #490)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

* Bump
* Added a `bump.sh` script ;-)
@eladb eladb requested a review from mindstorms6 August 8, 2018 12:57
@eladb eladb requested review from RomainMuller and rix0rrr and removed request for mindstorms6 August 8, 2018 12:57
@eladb
Copy link
Contributor Author

eladb commented Aug 8, 2018

@RomainMuller can you make sure to update the commit message with the list of "fixes" from the PR description above when you merge?

@RomainMuller
Copy link
Contributor

@eladb - my traditional workflow is to copy the PR description in the commit message :)

Copy link
Contributor Author

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@RomainMuller
Copy link
Contributor

Actually merging the new package from @rix0rrr's recently shipped #525, so it follows the cohort's version.

@RomainMuller RomainMuller merged commit db2ac62 into master Aug 8, 2018
@RomainMuller RomainMuller deleted the benisrae/v0.8.1 branch August 8, 2018 15:04
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

3 participants