-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Toolkit: support profiles #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /** | ||
| * A reimplementation of JS AWS SDK's SharedIniFile class | ||
| * | ||
| * We need that class to parse the ~/.aws/config file to determine the correct | ||
| * region at runtime, but unfortunately it is private upstream. | ||
| */ | ||
|
|
||
| import AWS = require('aws-sdk'); | ||
| import os = require('os'); | ||
| import path = require('path'); | ||
|
|
||
| export interface SharedIniFileOptions { | ||
| isConfig?: boolean; | ||
| filename?: string; | ||
| } | ||
|
|
||
| export class SharedIniFile { | ||
| private readonly isConfig: boolean; | ||
| private readonly filename: string; | ||
| private parsedContents?: {[key: string]: {[key: string]: string}}; | ||
|
|
||
| constructor(options?: SharedIniFileOptions) { | ||
| options = options || {}; | ||
| this.isConfig = options.isConfig === true; | ||
| this.filename = options.filename || this.getDefaultFilepath(); | ||
| } | ||
|
|
||
| public getProfile(profile: string) { | ||
| this.ensureFileLoaded(); | ||
|
|
||
| const profileIndex = profile !== (AWS as any).util.defaultProfile && this.isConfig ? | ||
| 'profile ' + profile : profile; | ||
|
|
||
| return this.parsedContents![profileIndex]; | ||
| } | ||
|
|
||
| private getDefaultFilepath(): string { | ||
| return path.join( | ||
| os.homedir(), | ||
| '.aws', | ||
| this.isConfig ? 'config' : 'credentials' | ||
| ); | ||
| } | ||
|
|
||
| private ensureFileLoaded() { | ||
| if (!this.parsedContents) { | ||
| this.parsedContents = (AWS as any).util.ini.parse( | ||
| (AWS as any).util.readFileSync(this.filename) | ||
| ); | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention that we are using an undocumented api in the js sdk to actually parse the ini file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely wanted to open an issue, but I'd like to land this first so that I can point them to the code and say "see, this is what we've had to do to work around the API deficiencies".
Pointing to code is easier than describing :)