Skip to content

feat(sns): support cross-region subscription on imported topics #4917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nija-at merged 9 commits into from
Nov 10, 2019
Merged

feat(sns): support cross-region subscription on imported topics #4917

nija-at merged 9 commits into from
Nov 10, 2019

Conversation

@nija-at
Copy link
Contributor

@nija-at nija-at commented Nov 8, 2019

Use the 'region' property on subscribing to imported SNS topics so that
the user can avail cross-region subscriptions.

fixes #3842

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

feat(sns): support cross-region subscription on imported topics
bfb0e22 
Use the 'region' property on subscribing to imported SNS topics so that
the user can avail cross-region subscriptions.

fixes #3842
@nija-at nija-at requested a review from a team November 8, 2019 10:46
@nija-at nija-at requested a review from garnaat as a code owner November 8, 2019 10:46
@nija-at nija-at self-assigned this Nov 8, 2019
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Nov 8, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb suggested changes Nov 8, 2019
View reviewed changes
@nija-at nija-at requested a review from eladb November 8, 2019 13:57
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Nov 8, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Nov 8, 2019

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@SomayaB SomayaB added the contribution/core This is a PR that came from AWS. label Nov 8, 2019
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Nov 9, 2019

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Niranjan Jayakar added 2 commits November 9, 2019 20:36
@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Nov 9, 2019
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Nov 9, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb approved these changes Nov 10, 2019
View reviewed changes
packages/@aws-cdk/aws-sns/lib/subscription.ts
topicArn: props.topic.topicArn,
rawMessageDelivery: props.rawMessageDelivery,
filterPolicy: this.filterPolicy,
region: props.region,
Copy link
Contributor

@eladb eladb Nov 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, if region is the same as the current region, this will still work, correct? Otherwise we might need some exception here.

Copy link
Contributor Author

@nija-at nija-at Nov 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I was able to validate this by deploying a template.

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Nov 10, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Nov 10, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at merged commit 3dd194d into master Nov 10, 2019
@nija-at nija-at deleted the nija-at/sns-xregionsubs branch November 10, 2019 15:22
@dillon-odonovan dillon-odonovan mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garnaat garnaat Awaiting requested review from garnaat

1 more reviewer

@eladb eladb eladb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nija-at nija-at

Labels

contribution/core This is a PR that came from AWS. pr/do-not-merge This PR should not be merged at this time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[sns] support region property for SqsSubscription

4 participants

@nija-at @aws-cdk-automation @eladb @SomayaB