Skip to content

Conversation

@jogold
Copy link
Contributor

@jogold jogold commented Nov 7, 2019

Without it the bin is not hoisted to node_modules/.bin and cannot be called from
individual package directories.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Without it the bin is not hoisted to `node_modules/.bin` and cannot be called from
individual package directories.
@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold
Copy link
Contributor Author

jogold commented Nov 8, 2019

@eladb no code owner here? For you this one I presume.

@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@RomainMuller RomainMuller merged commit 2d034f1 into aws:master Nov 11, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold jogold deleted the compat-bin branch November 11, 2019 14:29
eladb pushed a commit that referenced this pull request Nov 11, 2019
Without it the bin is not hoisted to `node_modules/.bin` and cannot be called from
individual package directories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants