chore: fix author matching in Mergify configuration #4851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The operator should be ~= to match a regexp.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
reviewed
Nov 5, 2019
Contributor
eladb
left a comment
eladb
left a comment
There was a problem hiding this comment.
thanks! can you please provide details in the PR description as to what issue this solves and how it is fixed by your change?
Also, please follow PR checklist guidelines for PR title.
NGL321
approved these changes
Nov 9, 2019
RomainMuller
changed the title
eladb
pushed a commit
that referenced
this pull request
Nov 11, 2019
Fix the Mergify operator for author condition. The current value for `author` is meant to be a regexp so the `~=` operator must be used to match it, not just `=`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Mergify operator for author condition.
The current value for
authoris meant to be a regexp so the~=operator must be used to match it, not just=.