Skip to content

chore: enhance bump script to default to a minor version bump#4389

Merged
mergify[bot] merged 3 commits intomasterfrom
shivlaks/bump-enhancement
Oct 9, 2019
Merged

chore: enhance bump script to default to a minor version bump#4389
mergify[bot] merged 3 commits intomasterfrom
shivlaks/bump-enhancement

Conversation

@shivlaks
Copy link
Copy Markdown
Contributor

@shivlaks shivlaks commented Oct 7, 2019

Also supports any semVer string as input for scenarios where we want to release patches,
major versions, etc.

Made a switch to use standard-version to create a commit at the end of the bump.
standard-version also takes care of the CHANGELOG generation now.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@shivlaks
chore: enhance bump script to default to a minor version bump
7dda04a 
Also supports any semVer string as input for scenarios where we want to release patches, major versions, etc.
Made a switch to use standard-version to create a commit at the end of the bump. standard-version also takes
care of the CHANGELOG generation now.
@shivlaks shivlaks requested review from a team and eladb October 7, 2019 05:50
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 7, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 7, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb suggested changes Oct 7, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering why not also push this to a branch at the end? Any reason to leave these manual steps?

@eladb
Copy link
Copy Markdown
Contributor

eladb commented Oct 7, 2019

Taking back what I said about the push. Delivlib’s auto-bump will take care of it.

@eladb
Copy link
Copy Markdown
Contributor

eladb commented Oct 7, 2019

So basically just a couple of minor comments in the script.

@shivlaks
Copy link
Copy Markdown
Contributor Author

shivlaks commented Oct 7, 2019

Taking back what I said about the push. Delivlib’s auto-bump will take care of it.

I'm guessing you mean the tag. I held off on the branch and push because I felt it was a little heavy-handed. Might be good to test on a couple of releases and make sure we don't observe considerations I might've missed before we add it.

Having said that creating a branch and pushing to it should be as simple as adding it as a postcommit as part of the standard-version stanza in package.json

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 7, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks shivlaks requested a review from eladb October 7, 2019 18:16
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 9, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 9, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 11d18e0 into master Oct 9, 2019
@mergify mergify bot deleted the shivlaks/bump-enhancement branch October 9, 2019 13:59
@SomayaB SomayaB added the contribution/core This is a PR that came from AWS. label Nov 14, 2019
@SNYKabbott SNYKabbott mentioned this pull request Apr 24, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eladb eladb eladb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@eladb eladb

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shivlaks @aws-cdk-automation @eladb @SomayaB