Update JSII bundle #426
Merged
Update JSII bundle #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiroc
commented
Jul 28, 2018
packages/aws-cdk-dotnet/generate.sh
Outdated
| </configuration>" | ||
| echo $NUGET_CONFIG_CONTENT > ./src/NuGet.config | ||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
Remove superfluous newline.
Contributor
Author
There was a problem hiding this comment.
Also delete the original (hard-coded) NuGet.config.
eladb
approved these changes
Jul 29, 2018
Generate NuGet.config instead of hard-coding it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsii:0.7.4/maintenance. This branch contains all of the commits onjsii:mastersince the previous integration, with the exception of this breaking change. It also contains these changes, which have not yet been merged: Fix .npmignore to include .NET generator CLI. jsii#104 and Publish .NET Generator CLI as framework-dependent rather than self-contained jsii#105NuGet.configrather than hard-coding it.