Skip to content

Conversation

@skinny85
Copy link
Contributor

I need Jest to write some more complicated tests in #3716


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from rix0rrr August 30, 2019 22:08
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@skinny85 skinny85 force-pushed the chore/iam-tests-2-jest branch from 03cef1a to 0737f5b Compare August 30, 2019 22:26
@skinny85
Copy link
Contributor Author

Updated package-lock.json.

@rix0rrr rix0rrr merged commit 9a229d9 into master Sep 2, 2019
@skinny85 skinny85 deleted the chore/iam-tests-2-jest branch September 4, 2019 01:14
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants