Skip to content

ci(security-guardian): fix guardhooks-no-root-principals guard rule #36690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Jan 14, 2026
Merged

ci(security-guardian): fix guardhooks-no-root-principals guard rule #36690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec647ca
fix: improve guardhooks-no-root-principals-except-kms-secrets.guard r…
kumvprat Jan 14, 2026
d72a2dd
Merge branch 'main' into security_guardian_kms_key_rule_improvements
mergify[bot] Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions ...ecurity-guardian/rules/guard-hooks/guardhooks-no-root-principals-except-kms-secrets.guard
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,12 @@ rule NO_ROOT_PRINCIPALS_EXCEPT_KMS_SECRETS when %resources_no_root_principals !e
when Principal.AWS is_string {
Principal.AWS != /(?i):root$/
}
# Check if AWS is an array - only check string items
# Check if AWS is an array - only check string items, skip intrinsic functions
when Principal.AWS is_list {
when Principal.AWS[*] is_string {
Principal.AWS[*] != /(?i):root$/
Principal.AWS[*] {
when this is_string {
this != /(?i):root$/
}
}
}
}
Expand All @@ -45,7 +47,11 @@ rule NO_ROOT_PRINCIPALS_EXCEPT_KMS_SECRETS when %resources_no_root_principals !e
Principal.AWS != /(?i):root$/
}
when Principal.AWS is_list {
Principal.AWS[*] != /(?i):root$/
Principal.AWS[*] {
when this is_string {
this != /(?i):root$/
}
}
}
}
}
Expand All @@ -61,7 +67,11 @@ rule NO_ROOT_PRINCIPALS_EXCEPT_KMS_SECRETS when %resources_no_root_principals !e
Principal.AWS != /(?i):root$/
}
when Principal.AWS is_list {
Principal.AWS[*] != /(?i):root$/
Principal.AWS[*] {
when this is_string {
this != /(?i):root$/
}
}
}
}
}
Expand All @@ -77,11 +87,15 @@ rule NO_ROOT_PRINCIPALS_EXCEPT_KMS_SECRETS when %resources_no_root_principals !e
Principal.AWS != /(?i):root$/
}
when Principal.AWS is_list {
Principal.AWS[*] != /(?i):root$/
Principal.AWS[*] {
when this is_string {
this != /(?i):root$/
}
}
}
}
}
}
}
}
}
}
Loading