ci: security report workflow disclaimer #36432
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
aws-cdk-automation
added
the
pr/needs-maintainer-review
| ); | ||
| if (botComment) { | ||
| const disclaimer = '\n\n---\n\n⚠️ **Experimental Feature**: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined. Please review findings carefully.'; |
There was a problem hiding this comment.
Are we not providing information about merge from main to avoid findings unrelated to the PR?
There was a problem hiding this comment.
Thanks, I missed adding that.
Will include it in the disclaimer as well
There was a problem hiding this comment.
Updated the disclaimer
There was a problem hiding this comment.
This how the disclaimer looks like right now
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status✅ The pull request has been merged at 1646c84 This pull request spent 8 seconds in the queue, with no time running CI. Required conditions to merge
|
|
Comments on closed issues and PRs are hard for our team to see. |
3 participants
Fix SQS inline policy guard rule and add experimental disclaimer to security reports
Issue
sqs-no-world-accessible-inline.guardwas checking incorrect resource type and property pathSolution
Fixed SQS inline policy rule:
AWS::SQS::Queueresources toAWS::SQS::QueueInlinePolicyresources per CloudFormation documentationProperties.QueuePolicy.StatementtoProperties.PolicyDocument.StatementAdded experimental disclaimer:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license