fix(lambda): add token resolution validation to capacity providers #36275
Conversation
github-actions
bot
added
the
beginning-contributor
|
@reedham-aws Can we have some unit tests that cover the edge of these properties being provided as tokens instead of exact values ? |
| new lambda.CapacityProvider(stack, 'MyCapacityProvider', { | ||
| capacityProviderName: tokenName, | ||
| maxVCpuCount: cdk.Token.asNumber(tokenMaxVCpu), | ||
| subnets: tokenSubnets.map((id, i) => ec2.Subnet.fromSubnetId(stack, `TokenSubnet${i}`, id)), |
There was a problem hiding this comment.
Is it possible to have assertions on subnets and securityGroups values in the checks below ?
There was a problem hiding this comment.
Added extra assertions for this in the tests
|
I'm not sure if the integration tests need to be updated here, it looks like other Lambda integ tests don't test token resolution. |
kumvprat
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status✅ The pull request has been merged at 684286e This pull request spent 6 seconds in the queue, with no time running CI. Required conditions to merge
|
|
Comments on closed issues and PRs are hard for our team to see. |
3 participants
Issue # (if applicable)
N/a
Reason for this change
Current validation of fields for recent capacity provider additions in
aws-lambdadoes not take into account unresolved tokens.Description of changes
Added
Token.isUnresolved()checks before all new validations. This ensures that validation only occurs when concrete values are provided, while still allowing tokens to pass through for CloudFormation resolution.Describe any new or updated permissions being added
N/a
Description of how you validated changes
Changes should be only internal, validated that unit and integration tests continued to work.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license