-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(imagebuilder-alpha): add support for Image Pipeline Construct #36153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e0e20dd to
eb8afb7
Compare
Pull request has been modified.
cdecf33 to
6087d42
Compare
packages/@aws-cdk/aws-imagebuilder-alpha/lib/private/image-and-pipeline-props-helper.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/private/image-and-pipeline-props-helper.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/private/image-and-pipeline-props-helper.ts
Outdated
Show resolved
Hide resolved
Pull request has been modified.
packages/@aws-cdk/aws-imagebuilder-alpha/lib/private/policy-helper.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/private/policy-helper.ts
Outdated
Show resolved
Hide resolved
6ed8b8f to
f0a2266
Compare
Pull request has been modified.
Pull request has been modified.
b2cd86b to
a890ee4
Compare
packages/@aws-cdk/aws-imagebuilder-alpha/test/image-pipeline.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/test/integ.all-parameters.image-pipeline.ami.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/test/integ.all-parameters.image-pipeline.container.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/private/policy-helper.ts
Outdated
Show resolved
Hide resolved
a890ee4 to
6e987ca
Compare
Pull request has been modified.
6e987ca to
ca4e570
Compare
ca4e570 to
4ccb839
Compare
| }), | ||
| ]; | ||
|
|
||
| const hasProps = props !== undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract these conditional permissions to separate helpers? We can follow up with this in separate PR as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can address in follow up PRs
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue
aws/aws-cdk-rfcs#789
Reason for this change
This change adds a new alpha module for EC2 Image Builder L2 Constructs (@aws-cdk/aws-imagebuilder-alpha), as outlined in aws/aws-cdk-rfcs#789. This PR specifically implements the ImagePipeline construct.
Description of changes
This change implements the ImagePipeline construct, which is a higher-level construct of CfnImagePipeline.
Example
Describe any new or updated permissions being added
N/A - new L2 construct in alpha module
Description of how you validated changes
Validated with unit tests and integration tests. Manually verified generated CFN templates as well.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license