Skip to content

Conversation

@krokoko
Copy link
Contributor

@krokoko krokoko commented Nov 10, 2025

Issue # (if applicable)

Add support for new properties in agentcore alpha package:

Also fix a warning (@param userPoolClients) in JSDoc due to wrong param name (missing 's')

Reason for this change

Supporting new features

Description of changes

Adding support for new properties, not changing existing implementation

Describe any new or updated permissions being added

Granting permissions on bucket when using code configuration as a runtime artifact

Description of how you validated changes

unit tests, integration tests, manual tests

Example:

  • Deploying a runtime from a zip available in S3:
const agentArtifact = AgentRuntimeArtifact.fromS3({
      bucketName: 'XXXXXXXXXX',
      objectKey: 'deployment_package.zip',
}, AgentCoreRuntime.PYTHON_3_13, ['main.py']);

const runtime1 = new Runtime(this, 'MinimalRuntime', {
      runtimeName: 'minimal_runtime',
      agentRuntimeArtifact: agentArtifact,
      requestHeaderConfiguration: { allowList: ['X-Amzn-Bedrock-AgentCore-Runtime-Custom-H1'] },
      lifecycleConfiguration: {
        idleRuntimeSessionTimeout: Duration.minutes(10),
        maxLifetime: Duration.hours(4),
      },
});

    // Grant permission to invoke Bedrock models
   ...
image
  • Deploying a browser with signing enabled
new BrowserCustom(this, 'Browser', {
      browserCustomName: 'my-browser',
      description: 'Strands browser',
      browserSigning: BrowserSigning.ENABLED,
    });
Screenshot 2025-11-19 at 4 53 22 PM

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@krokoko krokoko changed the title chore(agentcore): add new properties for runtime, browser feat(agentcore): add new properties for runtime, browser Nov 10, 2025
@github-actions github-actions bot added the p2 label Nov 10, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team November 10, 2025 23:26
@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Nov 10, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation added the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Nov 10, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 14, 2025 20:44

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@krokoko krokoko marked this pull request as ready for review November 19, 2025 22:57
@aws-cdk-automation aws-cdk-automation added pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. and removed pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. labels Nov 19, 2025
@alvazjor alvazjor self-assigned this Nov 20, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 20, 2025
@mergify mergify bot dismissed alvazjor’s stale review November 20, 2025 15:22

Pull request has been modified.

alvazjor
alvazjor previously approved these changes Nov 20, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed alvazjor’s stale review November 20, 2025 17:12

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #36003 has been manually updated.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 20, 2025
@krokoko
Copy link
Contributor Author

krokoko commented Nov 20, 2025

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2025

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

Details
  • sender-permission >= write

@alvazjor
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2025

refresh

✅ Pull request refreshed

@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 439495f into aws:main Nov 21, 2025
20 of 21 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants