-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(agentcore): add new properties for runtime, browser #36003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
packages/@aws-cdk/aws-bedrock-agentcore-alpha/agentcore/runtime/runtime-artifact.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-agentcore-alpha/agentcore/runtime/types.ts
Outdated
Show resolved
Hide resolved
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
|
This pull request has been removed from the queue for the following reason: The pull request #36003 has been manually updated. If you want to requeue this pull request, you can post a |
|
@Mergifyio requeue |
❌ Command disallowed due to command restrictions in the Mergify configuration.Details
|
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Add support for new properties in agentcore alpha package:
Also fix a warning (@param userPoolClients) in JSDoc due to wrong param name (missing 's')
Reason for this change
Supporting new features
Description of changes
Adding support for new properties, not changing existing implementation
Describe any new or updated permissions being added
Granting permissions on bucket when using code configuration as a runtime artifact
Description of how you validated changes
unit tests, integration tests, manual tests
Example:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license