Skip to content

Conversation

@aemada-aws
Copy link
Contributor

@aemada-aws aemada-aws commented Oct 30, 2025

When anyone modifies a workflow, mergify will fail to update the PR via a merge commit because of Github security which makes it look like Mergify is updating the workflows, which is disallowed without the workflows permission. This switches to rebase by default.

Signed-off-by: null <null>
@github-actions github-actions bot added the p2 label Oct 30, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 30, 2025 09:26
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 30, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aemada-aws aemada-aws changed the title ci(Mergify): configuration update ci(mergify): update PRs via rebase by default instead of merge commit Oct 30, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 30, 2025 09:30

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1d96d6b into main Oct 30, 2025
19 of 20 checks passed
@mergify mergify bot deleted the mergify/aemada-aws/config-update branch October 30, 2025 10:42
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants