Skip to content

Conversation

@leonmk-aws
Copy link
Contributor

@leonmk-aws leonmk-aws commented Aug 25, 2025

Issue # (if applicable)

Closes #35268.

Reason for this change

When moving the builds to github actions, need-xxx-review labels were not added anymore.

Description of changes

Fetch the build status from the github action, remove support for StatusEvent Github actions don't use it (only the direct Codebuild integration used it)

Description of how you validated changes

Manually ran the script for a few PR's locally, updated unit tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Aug 25, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team August 25, 2025 15:56
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 25, 2025
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort labels Aug 25, 2025
Copy link
Contributor

@kumvprat kumvprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new codebuild check also does commit status update.

Maybe that would be a better check as the status are updated when the workflow run is completed, this way for each commit the PR linter might not be successful in reporting the status of ongoing builds and mi9ght need to run again/run post codebuild workflow runs are complete

# Triggered from a separate job when a review is added
workflow_run:
workflows: [PR Linter Trigger]
workflows: ["PR Linter Trigger", "Codebuild PR Build"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should trigger the linter workflow again and add proper label based on Codebuild Action's result

Copy link
Contributor

@kumvprat kumvprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look good, main points to verify :

  • Does CodeBuild job completion trigger the linter workflow ?
  • Does the listWorkflowRuns client call support the data object being passed as a parameter?

@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit edae464 into aws:main Aug 26, 2025
18 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

‘needs-xxx-review’ label is not attached to the pull request that has passed all CI processes

2 participants