Skip to content

Conversation

@badmintoncryer
Copy link
Contributor

Issue # (if applicable)

Closes #35268

Reason for this change

The ‘needs-community/maintainer-review’ label would be attached to the pull requests which had passed all CI processes but this feature is failed now.

Description of changes

Update CODE_BUILD_CONTEXT to AWS CodeBuild us-east-1 (aws-cdk-github-actions-runner).

Describe any new or updated permissions being added

None

Description of how you validated changes

None

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 24, 2025 03:55
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Aug 24, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@badmintoncryer
Copy link
Contributor Author

exemption request
I think tests are not necessary for this modification.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Aug 24, 2025
@leonmk-aws leonmk-aws self-assigned this Aug 25, 2025
leonmk-aws
leonmk-aws previously approved these changes Aug 25, 2025
Copy link
Contributor

@leonmk-aws leonmk-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: see below

@leonmk-aws leonmk-aws added the pr/do-not-merge This PR should not be merged at this time. label Aug 25, 2025
@leonmk-aws leonmk-aws dismissed their stale review August 25, 2025 13:45

Unfortunately this only checks if the runner was successfully triggered not if the build was actually successful

@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@badmintoncryer
Copy link
Contributor Author

Thanks @leonmk-aws !

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort p2 pr/do-not-merge This PR should not be merged at this time. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

‘needs-xxx-review’ label is not attached to the pull request that has passed all CI processes

3 participants