- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.3k
fix(iam)!: deprecate OpenIdConnectProvider public API #35312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
❌ The title prefix of this pull request must be one of "feat|fix|build|chore|ci|docs|style|refactor|perf|test|revert"
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
| ➡️ PR build request submitted to  A maintainer must now check the pipeline and add the  | 
| Comments on closed issues and PRs are hard for our team to see. | 
Issue
Closes #20460.
Reason for this change
OpenIdConnectProvider, which uses CustomResource, should no longer be used. However, we still use it in EKS. It is superseded by OIDCProviderNative, which provides the same functionality by using the native CloudFormation resource, with less infrastructure complexity.Description of changes
Introduced internal construct
OpenIdConnectProviderInternal, which is a drop-in replacement forOpenIdConnectProvider, and changed EKS to use that. The change is breaking because we are changing the type that EKS is extending in its own implementation ofOpenIdConnectProviderfromOpenIdConnectProvidertoOpenIdConnectProviderInternal.Extend
OpenIdConnectProviderInternalwithOpenIdConnectProvider, but deprecate it.Describe any new or updated permissions being added
None.
Description of how you validated changes
Ran unit and integration tests. No feature changes.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license