-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(apigatewayv2): add disableSchemaValidation for Websocket api #35290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
bbb657c
2e2dee1
7303301
5489d59
4a50bc6
d28e20d
69dead7
babe72a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -94,6 +94,14 @@ export interface WebSocketApiProps { | |
| * @default undefined - AWS default is IPV4 | ||
| */ | ||
| readonly ipAddressType?: IpAddressType; | ||
|
|
||
| /** | ||
| * Avoid validating models when creating a deployment. | ||
| * @see https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-resource-apigatewayv2-api.html | ||
|
||
| * | ||
| * @default false | ||
| */ | ||
| readonly disableSchemaValidation?: boolean; | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -162,6 +170,7 @@ export class WebSocketApi extends ApiBase implements IWebSocketApi { | |
| description: props?.description, | ||
| routeSelectionExpression: props?.routeSelectionExpression ?? '$request.body.action', | ||
| ipAddressType: props?.ipAddressType, | ||
| disableSchemaValidation: props?.disableSchemaValidation, | ||
| }); | ||
| this.apiId = resource.ref; | ||
| this.apiEndpoint = resource.attrApiEndpoint; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line refers to the
arnForExecuteApiV2.The example and explanation for
arnForExecuteApiV2are separated by thedisableSchemaValidationsentences, which should be relocated to improve readability.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Moved the
disableSchemaValidationexplanation to its own section to avoid interrupting thearnForExecuteApiV2example and description flow.