Skip to content

feat(ecr-assets): add custom ECR repository and image tagging sup… #35251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

feat(ecr-assets): add custom ECR repository and image tagging sup… #35251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
4628449
feat(aws-ecr-assets): add custom ECR repository and image tagging sup…
oyiz-michael Aug 17, 2025
de66de8
feat(aws-ecr-assets): add integration tests for custom repository sup…
oyiz-michael Aug 17, 2025
57021cd
Merge branch 'main' into feature/ecr-custom-repository-support
oyiz-michael Aug 29, 2025
02c27a4
Update packages/aws-cdk-lib/aws-ecr-assets/lib/image-asset.ts
oyiz-michael Sep 2, 2025
c207cea
Merge branch 'main' into feature/ecr-custom-repository-support
oyiz-michael Sep 2, 2025
07333ae
Update packages/aws-cdk-lib/aws-ecr-assets/README.md
oyiz-michael Sep 3, 2025
0e230fc
Merge branch 'main' into feature/ecr-custom-repository-support
oyiz-michael Sep 3, 2025
85815ee
fix: lint issues in ECR custom repository implementation
oyiz-michael Sep 4, 2025
c7cb941
fix: remove integration test causing circular dependency
oyiz-michael Sep 6, 2025
3d8eabb
fix: resolve circular dependency by deactivating problematic integrat…
oyiz-michael Sep 6, 2025
8db24bd
Merge branch 'main' into feature/ecr-custom-repository-support
oyiz-michael Sep 6, 2025
ebc30ca
Merge branch 'aws:main' into feature/ecr-custom-repository-support
oyiz-michael Sep 8, 2025
bb0107d
Merge branch 'main' into feature/ecr-custom-repository-support
oyiz-michael Sep 9, 2025
b6fbd32
fix(aws-ecr-assets): add missing test fixtures for custom repository …
oyiz-michael Sep 9, 2025
3acf387
Merge branch 'main' into feature/ecr-custom-repository-support
oyiz-michael Sep 11, 2025
010e840
feat: rebuild ECR custom repository test suite with comprehensive Clo…
oyiz-michael Sep 13, 2025
8bc1d74
feat: reactivate pnpm dependencies integration test
oyiz-michael Sep 13, 2025
01ebb8a
fix: add missing IntegTest declaration for ECR custom repository inte…
oyiz-michael Sep 15, 2025
239a9f0
Merge branch 'main' into feature/ecr-custom-repository-support
oyiz-michael Sep 17, 2025
8ecaf7b
fix trailing space
oyiz-michael Oct 7, 2025
7dd7680
Merge branch 'main' into feature/ecr-custom-repository-support
oyiz-michael Oct 7, 2025
b32951d
fix: remove corrupted integ.custom-repository snapshot
oyiz-michael Oct 8, 2025
5640e23
feat: regenerate integ.custom-repository snapshot with correct refere…
oyiz-michael Oct 8, 2025
3326be3
fix: add token check before imageUri replacement
oyiz-michael Oct 8, 2025
c1ad2ef
fix: use Annotations.addError instead of throwing error for token check
oyiz-michael Oct 9, 2025
b2cd85b
fix: regenerate integ.custom-repository snapshot with actual AWS depl…
oyiz-michael Oct 9, 2025
eaff018
fix: return early after token validation error
oyiz-michael Oct 9, 2025
4a1cba6
test: update integ.custom-repository snapshot with correct custom tag…
oyiz-michael Oct 9, 2025
99122a3
Merge branch 'main' into feature/ecr-custom-repository-support
oyiz-michael Oct 9, 2025
bad5072
fix: handle unresolved tokens in custom tag implementation
oyiz-michael Oct 9, 2025
5eb0555
feat(core): support per-asset custom image tags in synthesizer
oyiz-michael Oct 9, 2025
41a1060
fix: remove trailing spaces in asset-manifest-builder
oyiz-michael Oct 9, 2025
15d497a
Merge branch 'main' into feature/ecr-custom-repository-support
oyiz-michael Oct 9, 2025
6f2f5a5
test: update integration test snapshot for custom ECR tags
oyiz-michael Oct 11, 2025
2fe8039
Merge branch 'main' into feature/ecr-custom-repository-support
oyiz-michael Oct 11, 2025
8f10cba
fix(ecr-assets): restore hash calculation for custom repository prope…
oyiz-michael Oct 13, 2025
e5caed1
Merge branch 'main' into feature/ecr-custom-repository-support
oyiz-michael Oct 13, 2025
5450875
Merge branch 'main' into feature/ecr-custom-repository-support
oyiz-michael Oct 18, 2025
353c26f
docs(aws-ecr-assets): clarify usage of externally managed ECR reposit…
Oct 18, 2025
4c1f6ce
test(aws-ecr-assets): update integration test snapshots for README ch…
Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...repository.js.snapshot/EcrCustomRepositoryTestDefaultTestDeployAssert85D554DF.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions ...pository.js.snapshot/EcrCustomRepositoryTestDefaultTestDeployAssert85D554DF.template.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions ...napshot/asset.05184bb384306c04f5f252e503170bc375f52d8a5803148b86e5c9188316a101/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions ....snapshot/asset.05184bb384306c04f5f252e503170bc375f52d8a5803148b86e5c9188316a101/index.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions ...napshot/asset.0750f79ef76f117846eb2cb4bf6089ac5548979a34df919eda4aed0c03e58c86/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions ....snapshot/asset.0750f79ef76f117846eb2cb4bf6089ac5548979a34df919eda4aed0c03e58c86/index.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions ...napshot/asset.56600b8907fdf5fe1ae6fdf12b0c782ab2c6a2791aa43e69434147ecb75703e3/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions ....snapshot/asset.56600b8907fdf5fe1ae6fdf12b0c782ab2c6a2791aa43e69434147ecb75703e3/index.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions ...napshot/asset.8edfe7607498bbd5722848a8b2f76ea961ec87deca4159b67a764c643bb7ba5f/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions ....snapshot/asset.8edfe7607498bbd5722848a8b2f76ea961ec87deca4159b67a764c643bb7ba5f/index.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions ...napshot/asset.c1bf4629db1d1a885f97f1564a08b49ede34928d386dd793b6a68dad2a260c7c/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions ....snapshot/asset.c1bf4629db1d1a885f97f1564a08b49ede34928d386dd793b6a68dad2a260c7c/index.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions ...napshot/asset.c25c167ce53bed796d130957066d4d9b138f8ee9e6162ad0575446a87c0252df/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions ....snapshot/asset.c25c167ce53bed796d130957066d4d9b138f8ee9e6162ad0575446a87c0252df/index.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ...ting/framework-integ/test/aws-ecr-assets/test/integ.custom-repository.js.snapshot/cdk.out
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 47 additions & 0 deletions ...s-ecr-assets/test/integ.custom-repository.js.snapshot/integ-custom-repository.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading