- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.3k
fix(secretsmanager): secret transformation #35202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(secretsmanager): secret transformation #35202
Conversation
* Use new transform to update from deprecated python 3.9 lambda runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
| Clarification Request | 
| I downloaded the branch to my local, and confirmed the changes are generating the rotation lambdas using python 3.10. I will add a exception to the test since they are in a nested stack within the integ tests stacks, and they are not being recognized, but I did check they end up creating lambdas with python v 3.10 for test packages/@aws-cdk-testing/framework-integ/test/aws-secretsmanager/test/integ.hosted-rotation.ts | 
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). | 
| This pull request has been removed from the queue for the following reason:  The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. | 
Pull request has been modified.
| Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). | 
| Comments on closed issues and PRs are hard for our team to see. | 
Issue # (if applicable)
Closes #34168
Reason for this change
Description of changes
Describe any new or updated permissions being added
none
Description of how you validated changes
existing unit tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license