fix(mergify): use check-success instead of status-success for GitHub Actions #35190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
requested changes
Aug 8, 2025
There was a problem hiding this comment.
revert this pls it's unrelated to the pr
There was a problem hiding this comment.
wrong PR to fix, sorry. Closed it
aws-cdk-automation
requested changes
Aug 8, 2025
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Mergify automatic PR merging after commit 708383b removed CodeBuild requirement.
Root Cause: CodeBuild uses GitHub Status API while GitHub Actions uses GitHub Checks API. Mergify was looking for status checks instead of check runs.
Solution: Updated .mergify.yml to use check-success conditions instead of status-success for GitHub Actions workflows (validate-pr and build).
Changes:
This should restore automatic PR merging functionality that was broken when CodeBuild was removed.