Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Aug 6, 2025

Reason for this change

Enhance the CLI integration test workflow to provide more flexibility in triggering tests and better control over when integration tests run.

Description of changes

  • Add explicit trigger types: Specify explicit event types (opened, synchronize, reopened, labeled, unlabeled) instead of using the default catch-all
  • Enable manual triggering: Allow integration tests to be triggered manually via the pr/request-cli-integ-tests label, even when no CLI-related files have changed
  • Improve workflow logic: Update the condition to check for both file changes OR the presence of the manual trigger label

These changes provide maintainers with better control over when integration tests run, especially useful for testing scenarios where CLI changes might not be automatically detected or when manual testing is needed.

Describe any new or updated permissions being added

No new permissions are being added. This change only modifies workflow trigger conditions and logic.

Description of how you validated changes

  • Reviewed the workflow syntax and logic
  • Verified that the label-based triggering condition is properly formatted
  • Confirmed that existing functionality (automatic triggering on CLI file changes) remains intact

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

- Add explicit trigger types for pull_request_target events
- Allow manual triggering via pr/request-cli-integ-tests label
- Enhance workflow flexibility for testing scenarios
@aws-cdk-automation aws-cdk-automation requested a review from a team August 6, 2025 13:24
@github-actions github-actions bot added the p2 label Aug 6, 2025
@mrgrain mrgrain changed the title feat(ci): improve CLI integration test workflow triggers chore(ci): request CLI integration test by label Aug 6, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 6, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 6, 2025
Copy link
Member

@Abogical Abogical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 511e81d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7ebcf5c into main Aug 6, 2025
20 checks passed
@mergify mergify bot deleted the mrgrain/feat/ci/improve-cli-integ-test-workflow branch August 6, 2025 14:43
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants