fix(codebuild): support Windows Server Core 2022 image with on-demand capacity #35152
Conversation
mrgrain
changed the title
mrgrain
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
| new ImageTestStack(app, 'WinCore2019-3', WindowsBuildImage.WIN_SERVER_CORE_2019_BASE_3_0), | ||
| // Windows 2022 images are not supported for on-demand build projects | ||
| /* new ImageTestStack(app, 'WinCore2022-3', WindowsBuildImage.WIN_SERVER_CORE_2022_BASE_3_0), */ | ||
| new ImageTestStack(app, 'WinCore2022-3', WindowsBuildImage.WIN_SERVER_CORE_2022_BASE_3_0), |
There was a problem hiding this comment.
Is there an authoritative list for this? I'm thinking about how we maintain this list going forward when new versions are added.
There was a problem hiding this comment.
There's an API that can be queried. It doesn't contain this split of fleet vs on-demand that this PR is removing. But then again, I'm not sure why that split existed in the first place.
codebuild:ListCuratedEnvironmentImages API command
There was a problem hiding this comment.
[Not a blocker for this PR] Do you think there is value in documenting this? i.e. which API to query when we want to update the list.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mergify
bot
deleted the
mrgrain/feat/aws-codebuild/windows-core-2022-support
branch
|
Comments on closed issues and PRs are hard for our team to see. |
3 participants
Issue # (if applicable)
N/A
Reason for this change
When support for the Windows Server Core 2022 image in AWS CodeBuild was initially added in #29754, the image type was not yet available for use with on-demand capacity.
This has now changed apparently (and tested), so we can remove the validation preventing use.
Additional removed a future looking test, since it is bad practices to add validations for the future without clearly documented evidence that this is going to happen.
I've searched the current docs, and there's no note whatsoever that Windows Server Core 2022 images are not supported with on-demand capacity.
Description of changes
Describe any new or updated permissions being added
No new or updated IAM permissions are required for this change.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license