Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 4, 2025

This PR updates the enum values for kms.

@github-actions github-actions bot added contribution/core This is a PR that came from AWS. pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Aug 4, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 4, 2025
@vishaalmehrishi vishaalmehrishi self-assigned this Aug 4, 2025
@vishaalmehrishi vishaalmehrishi added the pr/do-not-merge This PR should not be merged at this time. label Aug 4, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 4, 2025
@vishaalmehrishi vishaalmehrishi removed their assignment Aug 5, 2025
@ozelalisen ozelalisen self-assigned this Aug 6, 2025
Copy link
Member

@ozelalisen ozelalisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishaalmehrishi vishaalmehrishi removed the pr/do-not-merge This PR should not be merged at this time. label Aug 6, 2025
@vishaalmehrishi vishaalmehrishi dismissed their stale review August 6, 2025 11:24

Dismissing my own review since I made the required changes. The PR has been reviewed by a maintainer.

@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 62d4d1f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e128b29 into main Aug 6, 2025
24 checks passed
@mergify mergify bot deleted the enum-update/kms branch August 6, 2025 11:49
@github-actions
Copy link
Contributor Author

github-actions bot commented Aug 6, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants