Skip to content

ci(cdk-release): fix bug marking stable changes as alpha #35012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

ci(cdk-release): fix bug marking stable changes as alpha #35012

merged 1 commit into from
Aug 1, 2025

Conversation

@Abogical
Copy link
Member

@Abogical Abogical commented Jul 18, 2025 •
edited
Loading

Issue #34907

Closes #34907.

Reason for this change

Changelog generation sometimes treats stable changes as alpha changes.

Description of changes

  • "BREAKING CHANGE TO EXPERIMENTAL CHANGES" is changed to just "BREAKING CHANGES", there's no guarantee that the all breaking changes are limited to alpha modules.
  • alpha package scopes will not be treated as equal to stable package scopes.
  • The phrase "CHANGES TO L1 RESOURCES" will be treated as a note group similar to "BREAKING CHANGES". The description of L1 change commits should use the phrase "CHANGES TO L1 RESOURCES" instead of "BREAKING CHANGES".

Describe any new or updated permissions being added

No new permissions are added.

Description of how you validated changes

Unit tests added.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p1 labels Jul 18, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 18, 2025 11:45
@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Jul 18, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 18, 2025
@Abogical Abogical force-pushed the fix-changelog-marks-stable-as-alpha branch 2 times, most recently from 27a6278 to b7b2fbe Compare July 18, 2025 12:02
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 18, 2025
@Abogical Abogical added the pr/do-not-merge This PR should not be merged at this time. label Jul 23, 2025
alvazjor
alvazjor previously approved these changes Jul 24, 2025
View reviewed changes
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 24, 2025
@Abogical
Copy link
Member Author

Abogical commented Jul 24, 2025 •
edited
Loading

@alvazjor Just want to note, that there are still changes needed to treat L1 change commits differently. This is still a WIP hence the do-not-merge label.

@Abogical Abogical added the pr/work-in-progress This PR is a draft and needs further work. label Jul 24, 2025
@alvazjor alvazjor dismissed their stale review July 25, 2025 14:48

Dismissing previous approval for further review

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 25, 2025
@Abogical Abogical force-pushed the fix-changelog-marks-stable-as-alpha branch from b7b2fbe to d4da921 Compare July 25, 2025 14:54
@Abogical Abogical removed pr/work-in-progress This PR is a draft and needs further work. pr/do-not-merge This PR should not be merged at this time. labels Jul 25, 2025
@Abogical Abogical force-pushed the fix-changelog-marks-stable-as-alpha branch from d4da921 to ff842a4 Compare July 25, 2025 15:05
@github-actions github-actions bot mentioned this pull request Aug 1, 2025
Closed
@alvazjor alvazjor self-assigned this Aug 1, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 1, 2025
@Abogical
Copy link
Member Author

Abogical commented Aug 1, 2025

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@Abogical
Copy link
Member Author

Abogical commented Aug 1, 2025

@Mergifyio rebase

@Abogical
ci(cdk-release): fix bug marking stable changes as alpha
87c4fd2 
- "BREAKING CHANGE TO EXPERIMENTAL CHANGES" is changed to just "BREAKING CHANGES" as breaking L1 changes can be included in that list.
- alpha package scopes will not be treated as equal to stable package scopes.

Fixes #34907
@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2025

rebase

✅ Branch has been successfully rebased

@Abogical Abogical force-pushed the fix-changelog-marks-stable-as-alpha branch from be6a6e8 to 87c4fd2 Compare August 1, 2025 10:20
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Aug 1, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 87c4fd2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4eda24b into main Aug 1, 2025
19 checks passed
@mergify mergify bot deleted the fix-changelog-marks-stable-as-alpha branch August 1, 2025 10:58
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alvazjor alvazjor alvazjor approved these changes

Assignees

@alvazjor alvazjor

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. p1 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ec2: change marked as alpha in release notes

3 participants

@Abogical @aws-cdk-automation @alvazjor