Skip to content

Conversation

@leonmk-aws
Copy link
Contributor

@leonmk-aws leonmk-aws commented Jul 8, 2025

Issue # (if applicable)

Related to #33623.

Reason for this change

CDK has announced end of support for Node.js 14.x and 16.x on May 30th, 2025.

Description of changes

  • Marked the Node 16 as deprecated in the custom resource provider (annotation)
  • Updated the linter rule
  • Replaced node versions in package.json
  • Ran the linter to verify

Description of how you validated changes

Ran the linter

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 8, 2025 15:53
@github-actions github-actions bot added the p1 label Jul 8, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 8, 2025
@mrgrain
Copy link
Contributor

mrgrain commented Jul 8, 2025

@leonmk-aws You want to make this something else than a chore, so it shows up in the changelog. I reckon feat is appropriate.

@leonmk-aws leonmk-aws changed the title chore: drop support for Node <= 18.0.0 feat: drop support for Node <= 18.0.0 Jul 9, 2025
@leonmk-aws leonmk-aws changed the title feat: drop support for Node <= 18.0.0 feat: drop support for Node.js <= 18.0.0 Jul 9, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@leonmk-aws leonmk-aws marked this pull request as ready for review July 22, 2025 09:23
@leonmk-aws leonmk-aws requested a review from a team as a code owner July 22, 2025 09:23
@Abogical Abogical self-assigned this Jul 28, 2025
@Abogical Abogical added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 28, 2025
@Abogical
Copy link
Member

@leonmk-aws You want to make this something else than a chore, so it shows up in the changelog. I reckon feat is appropriate.

I think a fix or refactor label should me more appropriate.

@Abogical Abogical changed the title feat: drop support for Node.js <= 18.0.0 refactor: drop support for Node.js <= 18.0.0 Jul 31, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 31, 2025 16:22

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 31, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 1, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Abogical
Copy link
Member

Abogical commented Aug 1, 2025

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2025

rebase

✅ Branch has been successfully rebased

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5b7739f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 40a5123 into aws:main Aug 1, 2025
19 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants