chore: npm-check-updates && yarn upgrade #34888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
added
auto-approve
contribution/core
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aws-cdk-automation
force-pushed
the
automation/yarn-upgrade
branch
from
993a57a to
4a0eba1
Compare
Contributor
|
Reran the workflow because there were conflicts: https://github.com/aws/aws-cdk/actions/runs/16138538595 |
leonmk-aws
force-pushed
the
automation/yarn-upgrade
branch
from
4a0eba1 to
4523498
Compare
aws-cdk-automation
force-pushed
the
automation/yarn-upgrade
branch
2 times, most recently
from
06ff40a to
6c4bef9
Compare
leonmk-aws
added
pr/do-not-merge
1 task
aws-cdk-automation
force-pushed
the
automation/yarn-upgrade
branch
2 times, most recently
from
50242c2 to
2d2fafc
Compare
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
### Issue # (if applicable) Related to the #34888 PR. This PR contains the commit created by the Github action (that doesn't build) and another commit with the fix (making it easier to review). ### Reason for this change Version 6.0.0 of `@types/minimatch` got released on [NPM](https://www.npmjs.com/package/@types/minimatch) which deprecates the package and now the package doesn't contain code anymore (see files on NPM). We cannot upgrade our version of `glob` as this requires Node.js 20, see #33231 ### Description of changes Pin `@types/minimatch` to the previous working version. This has a side effect: lerna uses a pinned version of @types/minimatch (you can verify this with `yarn why @types/minimatch` with version `3.x.x`, now it will use `5.1.2`. As the build still passes I think this doesn't have consequences. I also removed `@types/minimatch` from the `nohoist` as this line doesn't have any effect since all the packages in the repo now use the same version. ### Description of how you validated changes Build, integ and unit tests. Ran `yarn why @types/minimatch` to confirm that all the packages use the same version of minimatch. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws-cdk-automation
force-pushed
the
automation/yarn-upgrade
branch
from
2d2fafc to
4e2061d
Compare
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
added
the
pr/needs-maintainer-review
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
aws-cdk-automation
force-pushed
the
automation/yarn-upgrade
branch
from
bc7178f to
74d56a9
Compare
Collaborator
Author
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran npm-check-updates and yarn upgrade to keep the
yarn.lockfile up-to-date.