feat(events): add `arnForPolicy` attribute for api destination #34315

badmintoncryer · 2025-04-30T11:24:31Z

Issue # (if applicable)

None

Reason for this change

L1 construct has arnForPolicy attribute but L2 construct does not support this.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-events-apidestination.html#aws-resource-events-apidestination-return-values#aws-resource-events-apidestination-return-values-fn--getatt

Description of changes

Add apiDestinationArnForPolicy to ApiDestinationAttributes and attribute of IApiDestination

Describe any new or updated permissions being added

None

Description of how you validated changes

Add both unit and integ tests

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

badmintoncryer · 2025-04-30T11:26:17Z

packages/aws-cdk-lib/aws-events/lib/api-destination.ts

+   * @see https://docs.aws.amazon.com/service-authorization/latest/reference/list_amazoneventbridge.html#amazoneventbridge-resources-for-iam-policies
+   * @attribute
+   */
+  readonly apiDestinationArnForPolicy?: string;


Considering the existence of users who are using IApiDestination, I made the definition optional to avoid breaking changes.

Pull request has been modified.

badmintoncryer · 2025-05-08T00:43:12Z

@QuantumNeuralCoder Could you please confirm this PR again?

ozelalisen

LGTM!

badmintoncryer · 2025-07-09T12:03:23Z

@mergify update

mergify · 2025-07-09T12:03:40Z

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov-upload.yml without workflows permission

Pull request has been modified.

badmintoncryer · 2025-07-10T02:51:11Z

@ozelalisen Could you please approve this again ?

mergify · 2025-07-10T09:12:45Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-07-10T09:44:54Z

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #34315 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.).

You can check the last failing draft PR here: #34939.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

ozelalisen · 2025-07-10T13:51:18Z

@Mergifyio requeue

mergify · 2025-07-10T13:51:24Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2025-07-10T15:02:19Z

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #34315 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.).

You can check the last failing draft PR here: #34954.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

badmintoncryer · 2025-07-10T15:03:24Z

@mergify update

mergify · 2025-07-10T15:03:44Z

update

✅ Branch has been successfully updated

aws-cdk-automation · 2025-07-10T15:35:19Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: c44b118
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-07-10T15:35:51Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-07-10T17:39:18Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

badmintoncryer added 4 commits April 30, 2025 18:38

add arnForPolicy

ab5273b

update

b39315c

update unit test

2af92ba

update readme

dce8b2d

github-actions bot added the p2 label Apr 30, 2025

aws-cdk-automation requested a review from a team April 30, 2025 11:24

github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Apr 30, 2025

badmintoncryer commented Apr 30, 2025

View reviewed changes

github-actions bot mentioned this pull request May 1, 2025

Monthly PR metrics report #34324

Closed

QuantumNeuralCoder and others added 4 commits May 1, 2025 13:00

Merge branch 'main' into events-attribute

311cbe2

Merge branch 'main' into events-attribute

1ab3e0b

update jsdoc

096b4bd

fix jsdoc

13608e5

QuantumNeuralCoder previously approved these changes May 5, 2025

View reviewed changes

badmintoncryer added 2 commits May 6, 2025 23:10

update unit test

5829b2d

Merge remote-tracking branch 'origin/main' into events-attribute

5812aea

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 6, 2025

badmintoncryer added 2 commits May 8, 2025 07:59

Merge branch 'main' into events-attribute

946fad7

Merge branch 'main' into events-attribute

66e588e

badmintoncryer added 5 commits May 19, 2025 00:31

Merge branch 'main' into events-attribute

601010f

Merge branch 'main' into events-attribute

5a65798

Merge branch 'main' into events-attribute

bf01ac8

Merge branch 'main' into events-attribute

fb7ef97

Merge branch 'main' into events-attribute

b1d05b7

ozelalisen self-assigned this Jul 9, 2025

ozelalisen previously approved these changes Jul 9, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 9, 2025

Merge branch 'main' into events-attribute

1bbb6d2

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 9, 2025

Merge branch 'main' into events-attribute

0b6f6df

ozelalisen approved these changes Jul 10, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 10, 2025

mergify bot added a commit that referenced this pull request Jul 10, 2025

Merge of #34315

46fbc66

mergify bot added a commit that referenced this pull request Jul 10, 2025

Merge of #34315

23da472

mergify bot mentioned this pull request Jul 10, 2025

merge queue: embarking main (e400228) and #34315 together #34939

Closed

30 tasks

mergify bot added a commit that referenced this pull request Jul 10, 2025

Merge of #34315

2253c76

mergify bot mentioned this pull request Jul 10, 2025

merge queue: embarking main (05afab3) and #34315 together #34954

Closed

30 tasks

Merge branch 'main' into events-attribute

c44b118

mergify bot added a commit that referenced this pull request Jul 10, 2025

Merge of #34315

4b84618

mergify bot mentioned this pull request Jul 10, 2025

merge queue: embarking main (05afab3) and #34315 together #34960

Closed

30 tasks

mergify bot merged commit e0ac9f8 into aws:main Jul 10, 2025
18 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2025

feat(events): add arnForPolicy attribute for api destination #34315

feat(events): add arnForPolicy attribute for api destination #34315

Uh oh!

Conversation

badmintoncryer commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

Uh oh!

badmintoncryer Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

badmintoncryer commented May 8, 2025

Uh oh!

ozelalisen left a comment

Choose a reason for hiding this comment

Uh oh!

badmintoncryer commented Jul 9, 2025

Uh oh!

mergify bot commented Jul 9, 2025

❌ Mergify doesn't have permission to update

Uh oh!

badmintoncryer commented Jul 10, 2025

Uh oh!

mergify bot commented Jul 10, 2025

Uh oh!

mergify bot commented Jul 10, 2025

Uh oh!

ozelalisen commented Jul 10, 2025

Uh oh!

mergify bot commented Jul 10, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

mergify bot commented Jul 10, 2025

Uh oh!

badmintoncryer commented Jul 10, 2025

Uh oh!

mergify bot commented Jul 10, 2025

✅ Branch has been successfully updated

Uh oh!

aws-cdk-automation commented Jul 10, 2025

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Jul 10, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(events): add `arnForPolicy` attribute for api destination #34315

feat(events): add `arnForPolicy` attribute for api destination #34315

badmintoncryer commented Apr 30, 2025 •

edited

Loading

badmintoncryer Apr 30, 2025 •

edited

Loading